DevExtreme.AspNet.Data.Tests.EFCore11#703
Open
mpreyskurantov wants to merge 1 commit intoDevExpress:masterfrom
Open
DevExtreme.AspNet.Data.Tests.EFCore11#703mpreyskurantov wants to merge 1 commit intoDevExpress:masterfrom
mpreyskurantov wants to merge 1 commit intoDevExpress:masterfrom
Conversation
mpreyskurantov
added
dependencies
There was a problem hiding this comment.
Pull request overview
Adds a new EF Core 11 test project and updates dependency documentation/CI to accommodate testing against Microsoft.EntityFrameworkCore.SqlServer 11.0.0-preview.1.26104.118.
Changes:
- Introduces
DevExtreme.AspNet.Data.Tests.EFCore11targetingnet11.0with an EF Core 11 previewVersionOverride. - Updates the solution to include the new test project.
- Updates dependency documentation and adjusts the CI composite action’s .NET SDK installation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
net/Directory.Packages.md |
Documents new net11.0 dependencies/projects and updates listed package versions. |
net/DevExtreme.AspNet.Data.sln |
Adds the new EF Core 11 test project to the solution and build configs. |
net/DevExtreme.AspNet.Data.Tests.EFCore11/DevExtreme.AspNet.Data.Tests.EFCore11.csproj |
New test project targeting net11.0 and referencing EF Core 11 preview SqlServer package. |
.github/actions/dotnet-test-build/action.yml |
Switches CI to install only 11.0.x SDK before building the solution. |
Comments suppressed due to low confidence (1)
net/Directory.Packages.md:234
- This section is labeled “Expected Directory.Packages.props file”, but the XML shown here does not match the current
net/Directory.Packages.propsstructure in the repo (that file lists PackageVersion items unconditionally rather than splitting by conditional ItemGroups). Either regenerate/update this “expected” snippet to reflect the actual file, or adjustDirectory.Packages.propsto match what’s documented here to avoid misleading future edits.
## Expected Directory.Packages.props file
```xml
<Project>
<PropertyGroup>
<NoWarn>NU1507</NoWarn>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<!-- Common (.NET/.NET Framework) PackageReferences -->
<ItemGroup>
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
<PackageVersion Include="System.Data.SqlClient" Version="4.8.6" />
<PackageVersion Include="System.Linq.Dynamic.Core" Version="1.6.0" />
<PackageVersion Include="System.Text.Json" Version="8.0.5" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.assert" Version="2.9.3" />
<PackageVersion Include="xunit.core" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
</ItemGroup>
<!-- .NET PackageReferences -->
<ItemGroup Condition="'$(TargetFramework)' == 'net10.0' Or '$(TargetFramework)' == 'net11.0' Or '$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
<PackageVersion Include="Azure.Identity" Version="1.14.2" />
<PackageVersion Include="DevExpress.Xpo" Version="25.1.7" />
<PackageVersion Include="FluentNHibernate" Version="3.4.1" />
<PackageVersion Include="LinqKit.Microsoft.EntityFrameworkCore" Version="6.1.9" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.19" />
<PackageVersion Include="Microsoft.Identity.Client" Version="4.77.1" />
<PackageVersion Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.1.2" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
<PackageVersion Include="Microsoft.Web.LibraryManager.Build" Version="2.1.175" />
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
<PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
</ItemGroup>
<!-- .NET Framework PackageReferences -->
<ItemGroup Condition="'$(TargetFramework)' == 'net462' Or '$(TargetFramework)' == 'net472'">
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer/11.0.0-preview.1.26104.118